RehabMan / HP-ProBook-4x30s-DSDT-Patch

This repository contains the ACPI patches (using Clover hotpatch) for a wide range of HP ProBook/EliteBook/ZBook laptops
Other
181 stars 71 forks source link

- fixed SSDT-USB-8x70 based on tests with EliteBook 8570p, normal dock and advanced dock #16

Closed Memphiz closed 6 years ago

Memphiz commented 6 years ago

As the title says. The former SSDT-USB-8x70 version didn't work correctly for my EliteBook 8570p. One onboard usb2 port was not working (was EH01 Hub1 HP12). Also the USB3 Hub on the advanced dock was not injected. Beside that all the comments were wrong too.

Not sure if this is really 8x70 generic or only 8570p.

For reference this is the ioreg for all notebook ports including the 4 usb2 ports on the normal dock:

https://www.dropbox.com/s/ryj9fdsoremxqnr/usb_normal_dock.ioreg?dl=0

and this is the ioreg from all usb2 and usb3 ports on the advanced dock:

https://www.dropbox.com/s/rv7ogt7hzea1h91/usb_advanced_dock.ioreg?dl=0

RehabMan commented 6 years ago

This needs cleanup. No idea why you changed the commented UsbConnector values (2 is not a typical value). USB2 only ports would be 0, USB3 ports would be 3. But of course, UsbConnector is not used for hub ports (which is why they are commented) as hub ports use portType instead.

And what is 'fard'?

Note: Commit looks like mostly an add of SS05/HP13. Correct?

Memphiz commented 6 years ago

That should read “far” and it basically adds HP12 and SS05 and tried to fix the comments to match what the 8570p has. Was unsure about those USB Connector types and can fix those. So it is 0 for USB2 - 3 for USB3 and nothing for Hubs?

Memphiz commented 6 years ago

i have added a second commit to revert the usbconnector comments and fixed the "fard" typo. In case thats all that is needed from your POV - I will squash the commits into a single one.

RehabMan commented 6 years ago

Please squash, then I'll review.

Memphiz commented 6 years ago

squashed