RehanSaeed / Schema.NET

Schema.org objects turned into strongly typed C# POCO classes for use in .NET. All classes can be serialized into JSON/JSON-LD and XML, typically used to represent structured data in the head section of html page.
MIT License
640 stars 80 forks source link

Fix HasValueX incorrectly returning true #676

Closed SmithPlatts closed 8 months ago

SmithPlatts commented 8 months ago

Overview

As per issue #675, when a whitespace string is passed to the Values(params object[] items) or Values(IEnumerable<object?> items) constructors of any of the Values<> classes, the HasValueX property will return true, where the corresponding ValueX will be empty.

Primary changes

Ancillary changes

Turnerj commented 8 months ago

Hey @SmithPlatts - thanks for this! I'll try and review it soon as what you described in this and corresponding issue make sense.