search

RehanSaeed / Schema.NET

Schema.org objects turned into strongly typed C# POCO classes for use in .NET. All classes can be serialized into JSON/JSON-LD and XML, typically used to represent structured data in the head section of html page.
MIT License
640 stars 80 forks source link

Add jobTitle to https://schema.org/Person #686

Closed chrispauly closed 2 months ago

chrispauly commented 2 months ago

Describe the feature

The property is defined on schema.org, but I don't see it on the Schema.NET Person object. https://webschemas.appspot.com/jobTitle

Schema objects

https://schema.org/Person

SmithPlatts commented 2 months ago

As per the docs:

This term is in the "new" area - implementation feedback and adoption from applications and websites can help improve our definitions.

It should be present in the Schema.NET.Pending package.

chrispauly commented 2 months ago

@SmithPlatts Thank you. I had a difficult time figuring out what is considered pending. I tried switching my project to Pending and didn't see it. But I see the mention now in Schema.org referring to that property being considered new. And I found a similar version of this question/issue asked a while ago. https://github.com/RehanSaeed/Schema.NET/issues/423

SmithPlatts commented 2 months ago

@chrispauly I had a look at the JSON-LD file and saw that the property is in the definition, but I didn't instantiate the package to actually validate if the property was there, just assumed.

Sorry.

Turnerj commented 2 months ago

Hey @chrispauly - if it is missing from Schema.NET.Pending, I'll do a new release with a newer version of the JSON-LD in a few days.

Thanks for pointing Chris in the right direction @SmithPlatts.

chrispauly commented 2 months ago

@Turnerj my testing was quick and maybe I didn't test it correctly. I just switched my packages.config package name and I can't even remember if I restored nugets. I thought I had, but may not have. I checked the code after making that swap and didn't see the property... but may've gotten confused. It's a daytime job and since it's the weekend for me... I won't be able to check again until Monday. I don't want you to do extra work if I just made a mistake.