search

RehanSaeed / Serilog.Enrichers.Span

Enrich Serilog log events with properties from Open Telemetry spans.
MIT License
95 stars 19 forks source link

This Repo is Now Deprecated #332

Open RehanSaeed opened 9 months ago

RehanSaeed commented 9 months ago

This repository is now deprecated. Serilog now has the native ability to log span related data. See https://github.com/serilog/serilog/pull/1955.

rmorrin commented 9 months ago

Can you provide guidance on how to migrate from Serilog.Enrichers.Span to the new Serilog-native equivalent?

It's not clear from reading the attached PR comments what steps are required, if any!

nblumhardt commented 9 months ago

The Serilog libraries are still a couple of months away from stabilizing, and there aren't any docs out there just yet. It's probably best to stick with this package in the meantime unless you have a strong reason to make the switch (happy to help if so!).

RehanSaeed commented 9 months ago

@rmorrin Serilog version 3.1 (unreleased at the time of writing) is most likely to contain the new span API's. Switching would be as simple as removing Serilog.Enrichers.Span and upgrading to Serilog to 3.1 and any other enrichers/sinks.

I will make this clearer in the ReadMe.

Sebazzz commented 8 months ago

Serilog.Extensions.Logging (which implements ILoggingFactory) indeed does provide SpanId and TraceId on LogEvent, however, nothing like ParentSpanId and SpanStart or similar is being enriched or added. Therefore, this library still has its use.

nblumhardt commented 8 months ago

@Sebazzz are you currently using this library with a back-end that can use span start/parent span id to display the events hierarchically? (Exploring this space currently... :))