search

Reidmcc / rockfish

Rockfish is an arbitrage bot for the Stellar Decentralized Exchange (SDEX)
MIT License
71 stars 23 forks source link

Switch `GetPaths` to use the net/url package instead of manual string building #16

Closed Reidmcc closed 5 years ago

Reidmcc commented 5 years ago

Describe the solution you'd like Right now the GetPaths function in dexWatcher builds the Horizon request string using strings.Builder. It would be both easier and clearer to use the net/url package and its helper functions. So instead of WriteString lines we'd have query.Add lines.

Reidmcc commented 5 years ago

manual string building is performing more consistently across Rockfish's API call functions, so don't do this.