search

Reidmcc / rockfish

Rockfish is an arbitrage bot for the Stellar Decentralized Exchange (SDEX)
MIT License
73 stars 23 forks source link

Remove deprecated mentions on code #23

Closed ghost closed 5 years ago

ghost commented 5 years ago

Deprecated by #19

Reidmcc commented 5 years ago

@dmcclccam looks good. While you're at it, could you remove the --iter flag since it's also deprecated?

ghost commented 5 years ago

Sure, done it! ^^

Reidmcc commented 5 years ago

thanks! If you'd like a challenge, you can try removing the old code that references those items. You'll want to check cmd/arbitcycle.go, arbitrageur/config.go, arbitrageur/arbitrageur.go, and examples/arbitconfig.cfg. I'll take care of it tonight otherwise.

ghost commented 5 years ago

Well, I tried to do it the "hardcore" way, directly from github's editor. Not a good idea...

Reidmcc commented 5 years ago

Hah, yeah, maybe not the best idea.

We may as well get rid of all of Start() in arbitrageur.go, it doesn't really work without the cycle iteration concept, and it isn't actually used in the current version. Which would leave just the iter flag stuff in arbitcycle.go.

ghost commented 5 years ago

Well, I will leave that last part on arbitrageur.go to you, as I'm pretty sure I'm missing something. 😅

Reidmcc commented 5 years ago

@dmcclccam you just deleted an extra } at the end of validateCliParams, otherwise you had it all right! Thanks for the help, this was on my get-around-to-it-soon list.