ReignBit / discord-kat

A Discord Bot for basic administration and fun, easily customizable via the online dashboard
https://kat.reign-network.co.uk
Other
3 stars 0 forks source link

[REWRITE] Fun cog is a mess #40

Closed ReignBit closed 3 years ago

ReignBit commented 3 years ago

Issue information

The fun module includes many of the same types of commands and uses a lot of repeating code. This is not DRY code and should be changed.

Possible changes

Remove all existing "emote" commands from Fun and create a prefab command which would be used for all emote commands.

def emote_cmd(self, emote, user, ctx):
    get_gif(emote)
    create_response(emote, user)
    return create_embed()
ReignBit commented 3 years ago

We already do this kind of method to an extent. I suppose the original commands lower in the file could do with using this system, but that is a low priority issue.