search

ReikaKalseki / Reika_FactorioMods_Issues

The issue tracker for all of my Factorio mods - EndgameCombat, NauvisDay, Geothermal, Oreverhaul, and the rest.
5 stars 1 forks source link

Endgame Combat: Load error with Titanium. PR provided for compatibility #320

Open brevven opened 3 years ago

brevven commented 3 years ago

Hello!

When trying to loading EndgameCombat with my Titanium mod I encountered an error. I've attempted to address that issue, as well as possible issues with my Tungsten mod in this PR: https://github.com/ReikaKalseki/EndgameCombat/pull/7

Let me know if you have any questions or concerns.

brevven commented 3 years ago

Note -- I've developed a workaround in Titanium for the incompatibility at the moment. The PR I provided might still be a better way of providing compatibility. Let me know what you think.

ReikaKalseki commented 3 years ago

I always check for items and not mods. However, as you can see, in some cases - especially in older code - I tended to assume if material A was present that B also was, because I only ever knew of A occurring in another mod (usually Bob's) that also added B.

brevven commented 3 years ago

Makes sense. Bob's was around way before any of my mods :)

Let me know if there's anything I can do to help out.