search

ReikaKalseki / Reika_Mods_Issues

The issue tracker for all of my mods - RotaryCraft, its addons, ChromatiCraft, and everything else.
46 stars 13 forks source link

[CrC] Focus Crystal progression not granted upon trading #2470

Open Shahelion opened 4 years ago

Shahelion commented 4 years ago

I traded with villagers for 9 of them, and didn't get it.

ReikaKalseki commented 4 years ago

Works for me. You clearly have some mod overriding villagers and thus nullifying DAPI's hooks that CC uses.

https://i.imgur.com/17zKKch.png

Shahelion commented 4 years ago

I honestly can't imagine which mod it is, because I don't have any that explicitly modify villagers, beyond adding new types.

Tinkers Construct, Witchery, and Forbidden Magic fall into that category.

ReikaKalseki commented 4 years ago

Witchery is my primary suspect, given those other two work fine for me.

Shahelion commented 4 years ago

Actually, just remembered: Witchery DOES do lots of stuff with Villagers. To my knowledge, does the following: Adds a new type or two Adds villager guards. These cannot be traded with. Some sort of interface allowing vampires to feed on them and convert them to thralls. This is my guess as to the culprit.

ReikaKalseki commented 4 years ago

Try removing it.

Shahelion commented 3 years ago

So, this is still an issue. I'd suggest move the trigger from trading to placing a Focus Crystal. If the player is placing one, then they must have traded for one or crafted one, it just prevents mods that do things with villagers from breaking this step.

ReikaKalseki commented 3 years ago

I have looked at my ASM hook again - the patch is done into the GUI/container code, meaning unless Witchery or anything else is changing that, nothing should be breaking.