search

ReikaKalseki / Reika_Mods_Issues

The issue tracker for all of my mods - RotaryCraft, its addons, ChromatiCraft, and everything else.
46 stars 13 forks source link

ASM conflict with Chunk Animator #2931

Open RaidhoSketch opened 3 years ago

RaidhoSketch commented 3 years ago

Playing Revolution 3 with some light add-ons, updated all the mods to v30d where applicable (ElectriCraft still v30a), the startup goes around midway trough loading the game (UCH, apparently), and then crashes. Tried reinstalling the whole deal and checking for mod duplicates, did not work.

Apparently caused by this: Reika.DragonAPI.Exception.ASMException$NoSuchASMMethodInstructionException: Error ASMing method func_78419_a ()V in net/minecraft/client/renderer/RenderList: (full crashlog here) crash-2021-11-14_01.59.36-client.txt

wamc2017 commented 3 years ago

Have you tried running it without Chunk Animator?

RaidhoSketch commented 3 years ago

Thanks! Seems like it was the issue. And we can stomach unanimated chunks just fine, so thanks again!

ReikaKalseki commented 3 years ago

What is the nature of their ASM patch?

Aivech commented 2 years ago

https://www.curseforge.com/minecraft/mc-mods/chunk-animator

I can't find source code for the 1.7.10 version but you could probably download the 1.7 jar and decompile it. The mod just animates chunks loading in.

HRudyPlayZ commented 2 years ago

I up this, it would be cool to be able to use your mods with Chunk Animator, They have an 1.8 version on Github so maybe there's a chance the 1.7 version is doing the same thing.

ReikaKalseki commented 2 years ago

No, there is no way the patches are similar.

HRudyPlayZ commented 2 years ago

Taking a look at the code using something like bytecode viewer could work. (it is legal, and i'm pretty sure the CA files for 1.7 are also under MIT since the license on the entire curseforge page says so anyways).

Looking at the ClassTransformer class, it seems to transform net.minecraft.client.renderer.RenderList and net.minecraft.client.renderer.WorldRenderer, in particular it seems to change the setPosition (func_78913_a) method inside the WorldRenderer and the func_78419_a method in the RenderList.

This might help you diagnose the issue and fix it more easily.

brandyyn commented 1 year ago

crash-2022-12-01_19.57.00-client.txt same crash as OP on load, this never used to happen. i used to play with chunk animator and all of reikas mods in 2018, so this is something that's changed on reikas side since then.