search

ReikaKalseki / Reika_Mods_Issues

The issue tracker for all of my mods - RotaryCraft, its addons, ChromatiCraft, and everything else.
46 stars 13 forks source link

[DragonRealm] TE machine frames required for Satisforestry miner are disabled and can't be crafted #3303

Open defaultuser1 opened 1 year ago

defaultuser1 commented 1 year ago

The Satisforestry Miner housing requires a connecting rod which requires machine frame (hardened). As far as I can tell these ( as well reinforced and resonant) as are not craftable with the current configs. These recipes are supposed to be modified by DragonRealm (more on this below) but I believe the problem is that the recipes are then being completely removed in the MineTweaker config scripts\tweaks.zs

recipes.remove(<ThermalExpansion:Frame:1>);
recipes.remove(<ThermalExpansion:Frame:2>);
recipes.remove(<ThermalExpansion:Frame:3>);

Removing these lines allows me to craft the recipes although the recipe modifications are mostly not working. I noticed the recipes are supposed to be being modified to use extra ingredients (HSLA/silicon/ruby/emerald) although there is code to do this in both DragonRealm/DRRecipeUtil.java:modifyTEUpgradeRecipe, as well as in the tweaks.zs file so I'm not sure if there is a conflict happening somewhere. The only change that successfully seems to work is the resonant machine frame requires an emerald now, but the other changes such as requiring HSLA ingots for the hardened machine frame don't appear to work. For what it's worth, the log reports that the modifyTeUpgradeRecipe seems to be working:

[21:47:24] [Server thread/INFO] [FML/ThermalExpansion]: DRAGON REALM CORE: Added emerald to TE upgrade recipe: Shaped Ore [[1xitem.thermalfoundation.material@72], [1xitem.thermalfoundation.material@135], [1xitem.thermalfoundation.material@72], null, 1xtile.thermalexpansion.machine@0, null, [1xitem.thermalfoundation.material@72], 1xitem.emerald@0, [1xitem.thermalfoundation.material@72]] > 1xtile.thermalexpansion.machine@0
[21:47:24] [Server thread/INFO] [FML/ThermalExpansion]: DRAGON REALM CORE: Added gating items to TE upgrade recipe: Shaped Ore [[1xitem.thermalfoundation.material@72], [1xitem.thermalfoundation.material@135], [1xitem.thermalfoundation.material@72], 1xitem.item.shaftcraft@1, 1xtile.thermalexpansion.machine@0, 1xitem.item.shaftcraft@1, [1xitem.thermalfoundation.material@72], 1xitem.emerald@0, [1xitem.thermalfoundation.material@72]] > 1xtile.thermalexpansion.machine@0
Waisse commented 2 months ago

Reika please fix for the literal 2 people playing your pack