ReikaKalseki / Reika_Mods_Issues

The issue tracker for all of my mods - RotaryCraft, its addons, ChromatiCraft, and everything else.
46 stars 14 forks source link

[Chromaticraft] "Ambient Effects" not unlocking #3325

Open shadoxxhd opened 10 months ago

shadoxxhd commented 10 months ago

I both brewed and drank a potion, yet the progress item does not unlock. Looking into the code, I can't seem to fine an associated "POTION.stepPlayerTo" call anywhere (clicking on the POTION entry in the enum and letting github search for other occurences; haven't locally cloned the repo to grep through it), though every other entry I checked has such a call somewhere in the codebase. Is this a bug, or is there something I'm not seeing?

edit: After manually searching for the term, I found the relevant code (so it does exist, githubs symbolic search just wasn't reliable). But I'm still not seeing why the progress item doesn't unlock for me, given that I've been affected by crystal potion effects, drank a potion, tried a splash potion on myself, got hit by witch potions, ... /chromaprog says missing research for BASICCRAFT: [BREWER], which in turn seems to depend on POTION progress...

Shahelion commented 9 months ago

Strange, I've had that trigger from all sorts of potion effects, usually from walking past a cave crystal or dying with Blood Magic (Soul Fray effect). Often happens in the first few hours of a world.

shadoxxhd commented 9 months ago

My problem wasn't that I never encountered potion effects, but that having potion effects didn't unlock the POTION progress item.