When encountering a Chromaticraft biome in the Spirit World dimension from Witchery, there is a NullPointerException caused by a mob spawner that doesn't have a tile entity (exception is caused at ChromaAux.java:185.)
I realise this is not an issue caused by ChromatiCraft. Admittedly I'm not 100% sure on the cause considering the weird circumstances behind it (and the fact Immersive Cavegen seems to be closed source), however I do think this crash shouldn't be happening in ChromatiCraft, and if it wasn't I don't think there would be any issues.
I see that to get the tile entity you use a DragonAPI class BlockSetData, with the method getTileEntity(). This then delegates to Coordinate.getTileEntity(), which can explicitly return null.
In this situation I don't think this code should be fail fast as doing so crashes the game, so I would expect a check for a null pointer when using a method that can explicitly return null. I'm not sure if you're open to pull requests (especially since I don't have the build scripts, so I can't test the changes), but I'd be happy to make the minor changes for this if so.
Involved mods:
Logs:
When encountering a Chromaticraft biome in the Spirit World dimension from Witchery, there is a
NullPointerExceptioncaused by a mob spawner that doesn't have a tile entity (exception is caused at ChromaAux.java:185.)I realise this is not an issue caused by ChromatiCraft. Admittedly I'm not 100% sure on the cause considering the weird circumstances behind it (and the fact Immersive Cavegen seems to be closed source), however I do think this crash shouldn't be happening in ChromatiCraft, and if it wasn't I don't think there would be any issues.
I see that to get the tile entity you use a DragonAPI class
BlockSetData, with the method getTileEntity(). This then delegates to Coordinate.getTileEntity(), which can explicitly return null.In this situation I don't think this code should be fail fast as doing so crashes the game, so I would expect a check for a null pointer when using a method that can explicitly return null. I'm not sure if you're open to pull requests (especially since I don't have the build scripts, so I can't test the changes), but I'd be happy to make the minor changes for this if so.