ReikaKalseki / Reika_Mods_Issues

The issue tracker for all of my mods - RotaryCraft, its addons, ChromatiCraft, and everything else.
46 stars 13 forks source link

Geostrata blocks can't be chiseled #384

Open Shahelion opened 9 years ago

Shahelion commented 9 years ago

Chisel in NEI: https://gyazo.com/826edf0258a57ef7519d718d3c9bd0c2

Actual Chisel: https://gyazo.com/4df99cb8c48eaba2647038bda9b0dc3a

I've tried several types, nothing works in a chisel.

ReikaKalseki commented 9 years ago

I noticed this as well. I have no idea how to fix it, especially given that NEI seems to recognize it.

Shahelion commented 9 years ago

Maybe worth noting that the cobble types can still be interchanged via Chisel, just not the patterns within a single type.

ReikaKalseki commented 9 years ago

Maybe worth noting that the cobble types can still be interchanged via Chisel

O_O

That is not even supposed to be possible.

Reignofmagic commented 9 years ago

Using the cobble interchange is how I made most of my base... I thought that was intended seeing as how you were adding chisel compat at the time

Shahelion commented 9 years ago

Well, they're all registered as cobble, I'm surprised the stone types can't be interchanged as well. Or maybe that's what's interfering.

ReikaKalseki commented 8 years ago

Well, they're all registered as cobble

So Chisel automatically assumes anything OreDicted together is chiselable? If so, then this is a unificator, with all associated exploits. If you have CC, try on its crystals. Not shards, the actual blocks.

Shahelion commented 8 years ago

Not everything OreDicted is chiselable, only certain intentional Ore Dictionary listings such as cobble, quartz, glass, and such. And the Quartz is only because Geostrata Smooth Quartz is OreDicted as quartz. The crystals shouldn't be interchangeable.

ReikaKalseki commented 8 years ago

I do not want to remove them from the OreDictionary...can I blacklist it?

Shahelion commented 8 years ago

Who's the current Chisel dev? They might have more information.

ReikaKalseki commented 8 years ago

I have no idea; the mod has changed hands so many times that I no longer know.

Shahelion commented 8 years ago

http://minecraft.curseforge.com/projects/chisel

This is the current version of Chisel that I'm using, and I believe it is also the most recently updated version for 1.7.10.

Drullkus commented 8 years ago

@ReikaKalseki What version of chisel are you using in your development? I cannot tell as you do not have build.gradle in your GeoStrata repo.

ReikaKalseki commented 8 years ago

I downloaded it about a month ago now. The API classes offer no clear version info, but if it helps, the package name has "cricketcraft" in it, and ChiselAPIProps has public static final String VERSION = "0.1.0";

Drullkus commented 8 years ago

@tterrag1098 might be a better person to talk to, as he is the one who manages the API.

tterrag1098 commented 8 years ago

@ReikaKalseki you are best off using the API jar from Chisel-2 version 2.5, as that is what will be most compatible, we haven't added anything significant since then.

There is no way to blacklist oredict blocks from groups at this time, but should definitely be possible, I'll look into adding that.

As for the broken integration that is the main topic of this issue, I'd have to pop Geostrata into my dev environment. @Zsashas what Chisel version are you using?

ReikaKalseki commented 8 years ago

@Zsashas ?

Shahelion commented 8 years ago

2.9.2.8

Shahelion commented 8 years ago

Still happens with Chisel 2.9.4.10

Shahelion commented 8 years ago

Wasn't sure whether to open a new issue or not, but Chisel still does not work with the variants of each stone (e.g. smooth to brick) despite NEI clearly showing that it's supposed to. Cobble types are also completely interchangeable.

Have you considered adding something like Minecraft PE's Stonecutter for making the different brick types? Would make it easier to make a specific pattern without having leftovers.

ChromatiCraft: V12e Chisel (ChiselTeam version): 2.9.5.11

ReikaKalseki commented 8 years ago

That entails adding a new block, TileEntity/recipe code, and GUI framework, a huge amount of overhead for a decorative mod.

dshadowwolf commented 8 years ago

I am seeing a variation of this issue. With the latest release of Chisel (well, Chisel 2) from Curseforge (2.9.5.11) only those blocks in GeoStrata that are also part of Chisel can be chiseled.

Is it possible that there is a need for defining the pattern/texture for the various chiseled states ?

TomeWyrm commented 8 years ago

@ReikaKalseki

Is this still an issue?

ReikaKalseki commented 8 years ago

No idea. @Builderb0y @HellFirePVP @HyperionNexus?

marlyn-x86 commented 8 years ago

I am able to replicate this bug.

Geostrata version: v16b Chisel Version: 2.9.5.11 (Obtained from this thread, the corresponding git repo is here. Did I grab the wrong fork of chisel? There appear to be many, and some forks do not offer the CricketCraft API that Geostrata looks for in Chisel)

Images of smooth/cobble peridotite in the chisel UI: here

TomeWyrm commented 8 years ago

Probably, yes. I can't remember what the "proper" version of chisel is anymore

dshadowwolf commented 8 years ago

I could try to see if I can trace the issue, but when I started looking into it - before deciding it was above my skill with Java - it looked as if the code, as implemented, should function. Yet it only worked for those blocks that were ore-dicted with ones supplied by Chisel.

The version listed by people above - Chisel 2.9.5.11 - is what I was using after research showed that it was the one providing the correct API hooks and class-structure. As it stands I am not sure what the issue here actually might be - it would take me quite a bit of time to grok the class layering and how the Chisel API is designed to work before I could give any further information.

Shahelion commented 8 years ago

Until this is resolved one way or another, I found this script someone made: https://minecraft.curseforge.com/projects/geochisel/files/2261515

Requires MineTweaker and ModTweaker.

Barhandar commented 4 years ago

Still an issue, you probably should strip out the offending code entirely so it doesn't appear in NEI.