search

Reimnop / Discord4Fabric

A beautiful Discord bot client for Fabric
MIT License
37 stars 20 forks source link

[Bug] !linked_account constraint, seems to halt messages if they are not linked #60

Open gadget78 opened 1 year ago

gadget78 commented 1 year ago

as tittle, when using the constraint !linked_account (so checking for unllinked players) this does NOT effect linked players, and all works and parse fine .. but unlinked players, it will actually halt their messages .. known about this for a while, only now got round to posted, as used a workaround ..

... going to ask this here as well, as kinda related, and i really hope this question doesn't confuse the matter of the above bug ... but if we wanted to add this as a "feature" (unlinked players chat isnt pushed to them or server) or expand that to have it so we can choose to turn all Minecraft messages off (to the server, but still parsed by custom events).. would it best to put that config within /MinecraftEventListeners.java like the discord !config.sendMessagesToDiscord config, or else where? (so that all other functions like custom events still work)

again Thankyou for this mod ! :)

Reimnop commented 1 year ago

Will work on it once I finish with my schoolyear!

gadget78 commented 1 year ago

its cool.. thankyou for quick reply...

im going to give adding the feature my self, will do a PR once i do .. do you think thats the best place to put entry ? whats best way to null the message event ? will look into the bug too, but bug bashing is much harder task lol .,.

gadget78 commented 1 year ago

managed to get this working, with help from some discord users in the "Fabric Server side Dev" so thanks to PotatoBoy, and Wesley1808...

added it as a PR ... will look into bug, but im not as confident with that ...