search

ReinBentdal / styled_widget

Simplifying widget style in Flutter.
https://pub.dev/packages/styled_widget
MIT License
1.27k stars 103 forks source link

null_safety #57

Closed vance-liu closed 3 years ago

vance-liu commented 3 years ago

fix #54, need test.

zhangruiyu commented 3 years ago

@ReinBentdal

vance-liu commented 3 years ago

Changed. I tested it in my project and everything is normal. I think you'd better test it again to make sure it can be used normally. THX.

zhangruiyu commented 3 years ago

@ReinBentdal

esDotDev commented 3 years ago

Any chance this could be landed soon?

ArneSaknussemm89 commented 3 years ago

Anything anyone can do to help this along? Wanting to update a couple apps to full nullsafety and this is the only outlier. And I really love using this package.

ReinBentdal commented 3 years ago

well, I unfortunately doesn't have the time at the moment to go through the entire package and verify the changes made. I see two possibilities to get it out fast. Either I can trust the code and push it out, or have someone else test and verify the changes.

esDotDev commented 3 years ago

I did a quick review and it does look pretty safe. Basically every single property was nullable already, so it's just a pass declaring everything as explicitly nullable and passing them unchanged to the flutter widgets.

Is there any sort of test suite you use internally?

zhangruiyu commented 3 years ago

I have been trying to use it for nearly half a month and have not found any problems so far

zhangruiyu commented 3 years ago

@ReinBentdal

ReinBentdal commented 3 years ago

@esDotDev i don't use any specific test suite. Since there have been some users of this, and since most of the properties anyways is nullable, I will accept the pull request and push a new version