Peer review 07-02 Giovanni - Githubissues

ReiniervanLimpt / web-app-from-scratch-1920

Web App From Scratch @cmda-minor-web 1920

https://reiniervanlimpt.github.io/web-app-from-scratch-1920/

1 stars 0 forks source link

Peer review 07-02 Giovanni #2

Open GiovanniKaaijk opened 4 years ago

GiovanniKaaijk commented 4 years ago

https://github.com/ReiniervanLimpt/web-app-from-scratch-1920/blob/cda93c951731cf252b4b06b81ac9f14b05a35e65/docs/index.html#L26 You forgot to add "" around the id

https://github.com/ReiniervanLimpt/web-app-from-scratch-1920/blob/cda93c951731cf252b4b06b81ac9f14b05a35e65/docs/index.html#L28 Change test to a meaningful id

https://github.com/ReiniervanLimpt/web-app-from-scratch-1920/blob/cda93c951731cf252b4b06b81ac9f14b05a35e65/docs/index.html#L21-L26 use <button type="submit"></button> within the form

Readme

Add a link to your live demo in Github Pages
Add an image of your work in the readme
Add a table of contents
Add a section of how to install the app
Add the features of the app
Add an example of the data
Maybe add a license