Closed acastle closed 1 year ago
Sorry, this PR ended up getting a bit bigger than I was hoping but at least there are some unit tests 😅
Ended up having to tackle a couple of bug fixes in the process, specifically around writing ini files when there are multiple values (current behavior only takes the last value). The other is a stack overflow on the spells ToString method due to the Before/After spell data props. I am actually surprised that no one tripped over the ToString one to this point, for me at least it causes both the VS2022 and Rider debuggers to crash if you ever put a breakpoint in Spell.cs. I must just be lucky.
Anywho, should be ready for another set of 👀 whenever yall have a moment.
Will take a look at this tomorrow, but just off the top of my head, saving multiple key/value (duplicates) was already done in Character Settings under SaveData(). You simply add to the section, and the writer figures out that you want to write it all out to disk. (a little hacky but wanted to keep very minimal changes to the IniFileParser) I am a little nervous having somone go into the ini area as its very easy to break things, but again will take a look at it tomorrow.
Sorry for the delay, I will get to it this week.
I've taken parts of this PR and a few edits as well and created another PR and its currently in master. Closing this PR for now. Ty for your work on this:)
Remove the hard coded list of rez spells in favor of a list which can be configured from the character ini.
72