search

RekkasGit / E3Next

10 stars 19 forks source link

Update Spell.cs #210

Closed jamescd23 closed 5 months ago

jamescd23 commented 6 months ago

Adds AugSlot parameter to query correct spell data when parsing item spell effects.

Most changes are formatting done by Visual Studio ¯_(ツ)_/¯

jonnyrocket0 commented 5 months ago

What problem does the Augslot stuff address? Are items with effects on augs not being used by e3? What is the purpose of the hunter class? The formatting changes make this pr very noisy and hard to tell what's actually a meaningful change

jamescd23 commented 5 months ago

Going to close this myself. Aside from your comments - which are legit - the PR ended up fairly well botched. The actual initial issue is legit though - without the changes, epic augs on EZServer don't work because the item itself is inspected, not the aug that is providing the click effect. At this stage I couldn't reasonably fix this PR, as my local repo now has sweeping changes well beyond this.