search

RekkasGit / E3Next

10 stars 19 forks source link

Fix for one-song melody's #232

Closed ckrahn closed 3 months ago

ckrahn commented 3 months ago

When using the loot-commander branch I had the issue with a melody containing only one song (in my case its just Selo's Travel Song for invis). I use "/playmelody invis force" to run it but that was no longer working.

I believe this code block here in Bard.cs is the issue.

A melody with 1 song will always trigger the if-block since trycounter (1) is > songs count (0) after dequeue.

Tested this with my bard and my melodys including the invis one were working again.

RekkasGit commented 3 months ago

Tyvm for tracing down the one off bug, I am updating the branch now

RekkasGit commented 3 months ago

note, i simply moved the ++ after the if check instead of inside the if condition.