[Bug] Assiston melee not following target consistently

[Lyricalpanda]

Latest pull on main seems to have issues with assistOn for melees. I've had melees that are positioned slightly incorrect - they're in range of the target, but not facing the target. Other times, they don't stick to the target if the target moves.

Examples:

Here, I dragged the mob from the original /assistOn command. Shugs is where the mob originally was. When I dragged the mob, Hilsud and Dalas correctly followed the mob. Shugs did not. I called /assistOn again, and Shugs would not reposition to be in range of target.

Here, Hilsud is in range of the mob, but is angled incorrectly so it cannot attack (You cannot see your target messages since wireframe is on).

Seems like /assistOn is not properly allowing toons to always follow mob/reposition if mob turns, and not properly allowing subsequent /assistOn calls to force a reposition on target.

Note, /assistOn with a new target will have all toons properly start in range on the mob and facing it.

[RekkasGit]

e3 doesn't keep the toon close to the mob, thats the job of the /stick command. When we recieve the "Your target is too far away, get closer!", we reduce the stick distance and recall stick .

Now, there is no code for 'you cannot see your target' and that may be something that needs to be addressed.

[RekkasGit]

I personally don't have a melee team , so will defer to shen/kem on this situations.

[RekkasGit]

Also note, multiple assistOn are ignored if currently assisting. The command is simply ignored. backoff -> assistme, would work tho.

[Shenlonx]

How consistent are you seeing this happen? I've seen issues occasionally with my melee toons, but I'd say extremely infrequently.

Also, can you post your melee [Assist Settings] if they differ from these settings:

[Assist Settings] Assist Type (Melee/Ranged/Off)=Melee Melee Stick Point=Behind Melee Distance=MaxMelee

[Lyricalpanda]

I was able to repro this on each mob I tried it on in cazicthule with kem once I noticed it. I'll try again later tonight, but seems pretty consistent if you drag (and/or turn the mob) the mob after calling /assistOn.

Assist settings are all

[Assist Settings]
Assist Type (Melee/Ranged/Off)=Melee
Melee Stick Point=Behind
Melee Distance=MaxMelee

[Lyricalpanda]

Although I did just switch from running background fps to frame limiter (1 fps background, 60 fps simulated), wonder if that's causing some issues with /stick? I'll do some more tests around that as well.

[Lyricalpanda]

Tested in Crushbone, with the following situations:

1) background FPS (settings) minimum framelimiter: enabled on background, 1FPS, simulated 60FPS

2) background FPS (settings) minimum framelimiter: enabled on background, 30 fps, simulated 60FPS

3) background FPS (settings) 30 framelimiter: disabled on background

I was still able to repro in all three situations. With background set to 30 fps it harder to repro (could have been luck though). Cazicthule zone was easier to repro than Crushbone, but I was still able to get consistent results constantly whiplashing the mob.

In this video, I actually got it on the first turn, which didn't normally happen in Crushbone. Sometimes I'd have to turn/move the mob multiple times to repro. In the video, this is done with all DPS using 30 FPS background, framelimiter off when in the background.

https://user-images.githubusercontent.com/1665885/209616182-b9700848-d325-49a1-be6f-4f8b0ab35acd.mp4

https://user-images.githubusercontent.com/1665885/209616186-b4c9c06f-cb35-438d-9bfd-453aa0bf704d.mp4

But it's sounding like this may be more of an issue with /stick than e3?

[RekkasGit]

I've made an update to add another check for "You cannot see your target." for melee to redo stick. can you test and see?

[Lyricalpanda]

Sure, I'll do the test later today. Thanks for the update.

[RekkasGit]

no update, closing till more info.

[Lyricalpanda]

I was able to see restick on "You cannot see your target" work a few times yesterday between LDONs and even in oasis. So that part is working 👍

I haven't tried to test around dragging the mob after calling assist to trigger a "You are too far from your target" type of message.

As a side note, I'm not sure why in e3next assisting isn't consistently in the back of the mob (in general). In legacy E3, the assists will consistently stay on the back side. I'm seeing that my melee will be maybe 30-45 degrees off from the back most of the time, and some of the assists are just on the side/in frontal cone of mob.