search

RelationalAI-oss / Rematch.jl

Pattern matching
Other
52 stars 6 forks source link

Add tests for QuoteNodes; remove TODO about them #16

Closed ghost closed 5 years ago

ghost commented 5 years ago

Remove TODO about QuoteNodes.

(Also, i learned about QuoteNodes today. TL;DR is i think we can ignore them and treat them just like any other literal: https://docs.julialang.org/en/v1/manual/metaprogramming/index.html#QuoteNode-1)

Closes https://github.com/RelationalAI-oss/Rematch.jl/issues/13

codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will increase coverage by 0.26%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   88.28%   88.54%   +0.26%     
==========================================
  Files           1        1              
  Lines         128      131       +3     
==========================================
+ Hits          113      116       +3     
  Misses         15       15
Impacted Files Coverage Δ
src/Rematch.jl 88.54% <ø> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0f6b6d...1ea4eda. Read the comment docs.

ghost commented 5 years ago

(Note that the TODO was originally added here: https://github.com/RelationalAI/raicode/commit/4cf0ec010b2cf295f2ef2886a244c607593a9950#diff-9d26fda85bbb6c222d4a9383a29b558bR28 )