search

RelationalAI-oss / Rematch.jl

Pattern matching
Other
52 stars 6 forks source link

Make MatchFailure a subtype of Exception #30

Closed charnik closed 2 years ago

charnik commented 2 years ago

The @match macro can throw an object of type MatchFailure. It'd make sense to let this type be a subtype of Exception so that it can be effortlessly caught in try-catch expressions.

charnik commented 2 years ago

@NHDaly Please let me know if this change should be reported at the end of the README.md file as yet another difference between Rematch.jl and Match.jl.

NHDaly commented 2 years ago

🤷 i don't know, i don't think you need to call this out in the README unless you want to.

Also, 👍 @nystrom is the real owner of this package, not me. Thanks for the review Nate :)

nystrom commented 2 years ago

Yeah, no need for the README change. Thanks @NHDaly

charnik commented 2 years ago

Thank you very much both of you for your prompt reviews!