search

RelationalAI-oss / Rematch.jl

Pattern matching
Other
52 stars 6 forks source link

Fix tests on Julia 1.0 #8

Closed mbravenboer closed 5 years ago

mbravenboer commented 6 years ago

Some of the testcases are failing in 1.0 because they are trying to assign to a global variable without the assignment using global. This is no longer supported (and 0.7 gives the deprecation warnings).

I'm thinking that the use-case of global variables is perhaps a little too uncommon and we should simply change the tests to not use global variables.

Does anybody feel like we should support a syntax that assigns to global variables? (I'm assuming that we don't want to infer this, consistent with opinion on other issues).

mbravenboer commented 6 years ago

@jamii Do you have an opinion/recommendation here?

ghost commented 5 years ago

Fixed by https://github.com/RelationalAI-oss/Rematch.jl/pulls/9