search

RelationalAI-oss / Rematch.jl

Pattern matching
Other
52 stars 6 forks source link

Pattern matching on field names #9

Closed raileywild closed 5 years ago

raileywild commented 6 years ago

Adds support for pattern matching of the form Foo(x=a,y=b) for issue #3. Added new tests and updated old ones to avoid deprecation warnings.

codecov-io commented 6 years ago

Codecov Report

Merging #9 into master will increase coverage by 3.97%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   88.99%   92.96%   +3.97%     
==========================================
  Files           1        1              
  Lines         109      128      +19     
==========================================
+ Hits           97      119      +22     
+ Misses         12        9       -3
Impacted Files Coverage Δ
src/Rematch.jl 92.96% <100%> (+3.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5359b46...f390b90. Read the comment docs.

raileywild commented 6 years ago

@mbravenboer any comments?

ghost commented 5 years ago

@raileywild: Is this good to merge then, or are you waiting for anything else?

raileywild commented 5 years ago

I believe @mbravenboer still has to comment/approve.

ghost commented 5 years ago

Oops, i forgot that #10 was based against this PR -- sorry to merge into your PR without asking, Ruy! 😖

Anyway, this PR now also includes wrapping all the tests in @testsets. -_- if you want, you can roll that back and i can re-merge #10 when this is done -- up to you.