search

RelationalAI / rai-sdk-java

The RelationalAI Software Development Kit (SDK) for Java.
Apache License 2.0
6 stars 1 forks source link

Added the Java version param with a default value if the caller does not provide matrix.java-version #33

Closed miazamrai closed 1 year ago

miazamrai commented 1 year ago

Removing the matrix strategy from the test workflow and action. Using the latest version of Java. Context: https://relationalai.atlassian.net/browse/RAI-8163

larf311 commented 1 year ago

The request was to remove the matrix from the the raicode workflow. It's fine to have them in the actions in this repo.

miazamrai commented 1 year ago

The request was to remove the matrix from the the raicode workflow. It's fine to have them in the actions in this repo.

The matrix.java-version needs to be defined by the caller or else some other variable has to be defined in the action in case matrix.java-version is not defined by the caller. I think defining an optional parameter with a default value is a good approach. This way caller can provide a different version if it wants to otherwise the default value will be used. If we don't use the param then we need to define a step which would return the java version as an output to be consumed by the setup java action like java-version: ${{ matrix.java-version || github.steps.java-version.output.version }}

miazamrai commented 1 year ago

The request was to remove the matrix from the the raicode workflow. It's fine to have them in the actions in this repo.

The matrix.java-version needs to be defined by the caller or else some other variable has to be defined in the action in case matrix.java-version is not defined by the caller. I think defining an optional parameter with a default value is a good approach. This way caller can provide a different version if it wants to otherwise the default value will be used. If we don't use the param then we need to define a step which would return the java version as an output to be consumed by the setup java action like java-version: ${{ matrix.java-version || github.steps.java-version.output.version }}

@larf311 Kindly check if the current approach makes sense.