Closed miazamrai closed 2 years ago
@larf311 @NRHelmi We need to do same kind of stuff for all the other SDKs, that is, moving the test code to a github action. It would be nice that we use the same folder github folder structure for all the SDKs.
@miazamrai so we don't need to redefine action.yml
in raicode
right ?
@miazamrai so we don't need to redefine
action.yml
inraicode
right ?
Yes, the other repository workflow will checkout the sdk and directly run the action from the sdk’s action folder.
Don't you need to (optionally) pass in the engine version?
Don't you need to (optionally) pass in the engine version?
it will be like this. https://github.com/RelationalAI/raicode/blob/276b5325acb9daca2d453903f3712c838a228fd9/.github/workflows/raicloud-bench-sdktest-all.yml#L27
Is there a reason not to make the engine version (or perhaps custom headers) an explicit input? It would make the action self documenting. As it is now, callers of this action need to know the special environment variable to set.
Is there a reason not to make the engine version (or perhaps custom headers) an explicit input? It would make the action self documenting. As it is now, callers of this action need to know the special environment variable to set.
I opted the env variable approach for the following reasons,
@larf311 If you are agree with the current approach then I will merge this to main.
- I don't really understand this argument.
I like #4
@larf311 Added the custom headers input param.
Moved the test code to be called as github action so that the source for testing via the python sdk resides on a single place. It will allow the consumers to absorb any changes made to the test logic.