Closed salamehsameera closed 2 years ago
@salamehsameera for question 1.
: I think you could get that piece by doing GET /transactions/{id}
? (except for the results format version, currently, which makes me think that we should actually return that from the backend's createTransaction()
response, and set it in Cosmos, so that you would get that there.
Does that sound reasonable?
okay, this should be ready to review now
This has been green since March; should we just merge it? π
Looking again, we should probably move this to the new naming scheme:
query
-> execv1
: v1 txnexec
: v2 & pollexec_async
: v2 & just return txn resourceThis would be a breaking change, so we'd have to be sure to bump the version number accordingly before we release (major version bump I think?)
+1 to both fronts. π we can do those in two different steps if it's easier.
This PR changes query
to be async + poll.
Maybe we should change this PR to leave query
unchanged, and add βquery + pollβ as exec
.
Can rename query
to exec_v1
later.
Yes, that's a great plan. π π Do you want to make that change while sameera's out? π
Yep, just pushed. Lmk how it looks
Thanks Pete! I'm following up on this now
The fast-path sync mode looks like:
Where the async with polling mode looks like:
This is based on https://github.com/RelationalAI/rai-sdk-python/pull/76. The base of this PR should be changed to main before merging.
The sync and async modes should look identical after closing out: