search

RelationalAI / rai-sdk-python

The RelationalAI Software Development Kit (SDK) for Python.
Apache License 2.0
17 stars 4 forks source link

Improve handling of string constants #9

Closed tomasrelai closed 3 years ago

tomasrelai commented 3 years ago

If I use a bogus size string in, say, create_compute, the error comes back as an HTTP error.

We should consider having an enumerated type for those strings, or perhaps validating them before sending out the request? It would also be nice to list the allowable strings (or types) in the docstring.

On the other hand, if the cloud environment, say, adds more sizes, if those are built into the library, then a new release of the library would be needed to support the new sizes. Wondering if there could be a separate API call that lists the valid sizes, then --- called once when the library is initialized / before the first request is made, perhaps.

bradlo commented 3 years ago

i updated the sdk to take an enum value for engine size, this does mean that if we add sizes to the API that we will need to update the sdk, but i think this is the right tradeoff, esp as we want to move away from explicitly managing engines in most cases.

billscheidel-rai commented 1 year ago

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-3716.

This link is only accessible to employees of RelationalAI.