RelativityMC / C2ME-fabric

A Fabric mod designed to improve the chunk performance of Minecraft.
MIT License
524 stars 47 forks source link

C2ME causes the world to save infinitely when used with betterchunkloading #243

Open rottakore opened 1 year ago

rottakore commented 1 year ago

Describe the bug Exiting the world the saving screen never finishes and the computer vents go crazy.

To Reproduce Steps to reproduce the behavior:

  1. Enter a world;
  2. Do something for about 5 or 10 minutes in the world;
  3. Try to exit.

Expected behavior The world saves quickly, leading you to the game main menu.

Screenshots 2023-09-06_09 26 35

Runtime info (please complete the following information):

Crash reports / logs The game doesn't crash, I need to force close it by task manager, the last console logs since I tried to exit the world are these: [09:25:19] [Render thread/INFO]: [voicechat] Clearing audio channels [09:25:19] [Netty Local Client IO #1/INFO]: Disconnected from server, resetting proxy config values [09:25:19] [Render thread/INFO]: [voicechat] Stopping microphone thread [09:25:19] [Render thread/INFO]: [voicechat] Disconnecting voicechat [09:25:19] [Render thread/INFO]: [FastQuit] Disconnected "???" from the client. [09:25:19] [Render thread/INFO]: Stopping worker threads [09:25:19] [Render thread/ERROR]: Signature is missing from Property textures [09:25:19] [Server thread/INFO]: o_ooooo lost connection: Desconectado [09:25:19] [Server thread/INFO]: oooooo_ saiu da partida [09:25:19] [Server thread/INFO]: [voicechat] Disconnecting client o_oo__ooo [09:25:19] [Server thread/INFO]: Stopping singleplayer server as player logged out [09:25:19] [Server thread/INFO]: [voicechat] Disconnecting client zetrakore [09:25:20] [Server thread/INFO]: Stopping server [09:25:20] [Server thread/INFO]: Saving players [09:25:20] [Server thread/INFO]: Saving worlds

[09:25:20] [Render thread/INFO]: [FastQuit] Exiting FastQuit. [09:25:20] [Render thread/INFO]: [FastQuit] Waiting for "???" to finish saving... [09:25:20] [CullThread/INFO]: [STDOUT]: Shutting down culling task!

[09:25:50] [Netty Server IO ICE #2/INFO]: b7aed8f5-b435-4592-b2d0-6d1c9ef8a164 channel inactive, closing.

[09:25:50] [Netty Server IO ICE #2/INFO]: b7aed8f5-b435-4592-b2d0-6d1c9ef8a164 closing QUIC. [09:25:50] [Netty Server IO ICE #2/INFO]: b7aed8f5-b435-4592-b2d0-6d1c9ef8a164 closed.

The process ended with code 1.

Other mods [✔] alternate-current-mc1.20-1.7.0 [✔] antighost-1.20-fabric0.83.0-1.1.5 [✔] appleskin-fabric-mc1.20-2.5.0 [✔] bclib-3.0.13 [✔] bendy-lib-fabric-4.0.0 [✔] betterchunkloading-fabric-1.20.1-2.1 [✔] bettercombat-fabric-1.7.3+1.20.1 [✔] better-end-4.0.10 [✔] betterfpsdist-fabric-1.20.1-3.9 [✔] better-nether-9.0.9 [✔] better-trees-1.7 [✔] c2me-fabric-mc1.20.1-0.2.0+alpha.10.100 [✔] cardinal-components-api-5.2.2 [✔] cavedweller-1.2.0 [✔] chunksending-fabric-1.20.1-2.6 [✔] clientcrafting-fabric-1.20.1-1.7 [✔] cloth-config-11.1.106-fabric [✔] Clumps-fabric-1.20.1-12.0.0.3 [✔] collective-1.20.1-6.65 [✔] connectivity-fabric-1.20.1-4.5 [✔] crawl-0.12.0 [✔] cupboard-fabric-1.20.1-1.9 [✔] Debugify-1.20.1+2.0 [✔] doubledoors-1.20.1-5.0 [✔] dynamiccrosshair-7.1+1.20-fabric [✔] dynamiccrosshair-compat-3.3+1.20.1 [✔] dynamic-fps-3.0.1+minecraft-1.20 [✔] elytraslot-fabric-6.3.0+1.20.1 [✔] enhancedblockentities-0.9+1.20 [✔] entityculling-fabric-1.6.2-mc1.20 [✔] essential_1-2-2_fabric_1-20-1 [✔] fabric-api-0.88.1+1.20.1 [✔] fabric-language-kotlin-1.10.10+kotlin.1.9.10 [✔] fallingleaves-1.15.2+1.20.1 [✔] FallingTree-1.20.1-4.3.0 [✔] fastquit-3.0.0-beta.2+1.20+ [✔] ferritecore-6.0.0-fabric [✔] firstperson-fabric-2.2.3-mc1.20 [✔] geckolib-fabric-1.20.1-4.2.2 [✔] gpumemleakfix-fabric-1.20.1-1.7 [✔] ImmediatelyFast-1.2.1+1.20.1 [✔] Incendium_1.20.1_v5.3.1 [✔] indium-1.0.25+mc1.20.1 [✔] InventoryProfilesNext-fabric-1.20-1.10.7 [✔] inventorytotem-1.20.1-3.0 [✔] iris-mc1.20.1-1.6.8 [✔] jamlib-0.6.1+1.20.x [✔] krypton-0.2.3 [✔] Ksyxis-1.1 [✔] language-reload-1.5.8+1.20.1 [✔] letmedespawn-fabric-1.20-1.1.0 [✔] libIPN-fabric-1.20-4.0.0 [✔] limitedchunks-fabric-1.20.1-3.8 [✔] lithium-fabric-mc1.20.1-0.11.2 [✔] Log-Begone-Fabric-1.20.1-1.0.8 [✔] logcleaner-1.0.0 [✔] lunade-fastanim-1.6-1.20 [✔] memoryleakfix-fabric-1.17+-1.1.2 [✔] modernfix-fabric-5.7.2+mc1.20.1 [✔] modmenu-7.2.1 [✔] moreculling-1.20.1-0.19.0 [✔] MoreCullingExtra-1.1-1.20.1 [✔] notenoughanimations-fabric-1.6.4-mc1.20 [✔] Nullscape_1.20.1_v1.2.2 [✔] nvidium-0.1.16-alpha [✔] nyctophobia-dread-1 [✔] owo-lib-0.11.1+1.20 [✔] player-animation-lib-fabric-1.0.2-rc1+1.20 [✔] recipe-book-is-pain-0.10.0-1.20.1 [✔] recipeessentials-fabric-1.20.1-1.8 [✔] recipe-unlocker-1.0.1 [✔] reeses_sodium_options-1.6.5+mc1.20.1-build.95 [✔] RegionsUnexploredFabric-0.5.1_02+1.20.1 [✔] right-click-harvest-3.2.3+1.19.x-1.20.1-fabric [✔] securecrops-1.0.4+1.20 [✔] servercore-fabric-1.3.7+1.20.1 [✔] sleepwarp-2.1.0+1.20 [✔] smoke-suppression-1.0.16+MC1.20-1.20.1 [✔] smoothchunk-fabric-1.20.1-3.1 [✔] sodium-extra-0.5.1+mc1.20.1-build.112 [✔] sodium-fabric-mc1.20.1-0.5.2 [✔] soulslike-weaponry-0.9.9.6-1.20-fabric [✔] structureessentials-fabric-1.20.1-3.0 [✔] TerraBlender-fabric-1.20.1-3.0.0.169 [✔] Terralith_1.20.1_v2.4.5 [✔] threadtweak-fabric-1.20.1-0.1.0 [✔] travelers-backpack-1.20.1-9.1.3 [✔] trinkets-3.7.1 [✔] vmp-fabric-mc1.20.1-0.2.0+beta.7.101-all [✔] voicechat-fabric-1.20.1-2.4.24 [✔] wraith-waystones-3.1.3+mc1.20 [✔] yet-another-config-lib-fabric-3.1.1+1.20 [✔] yosbr-0.1.2

Checklist

Additional context I first thought that the problem was in FastQuit, but when I disabled FastQuit the problem persisted, it only got back to normal when I disabled the Concurrent Chunk Management Engine.

ishland commented 1 year ago

Please provide full logs. Also try reproduce without betterchunkloading, smoothchunk, chunksending, limitedchunks.

rottakore commented 1 year ago

Full log provided below: 2023-09-06-1.log

I'll test without betterchunkloading, smoothchunk, chunksending and limitedchunks later and provide results.

rottakore commented 1 year ago

I discovered that the problem is exactly with C2ME and betterchunkloading, I'll provide the log below: latest2.log

ishland commented 1 year ago

Related to KingContaria/FastQuit#35

iMoobert commented 1 year ago

I have a similar issue where c2me will cause my world to take over a minute to save when quitting the game. This happens even when I join the world then immediately quit after.

I initially thought this was a problem with a mod called FastQuit, however the issue resolved itself when I removed c2me