RelativityMC / VMP-fabric

A Fabric mod designed to improve server performance at high playercounts.
MIT License
136 stars 8 forks source link

[INCOMPATIBILITY] v0.2.0+beta.3.73 and higher completely breaks Pehkui #21

Closed Tempest-5ky closed 1 year ago

Tempest-5ky commented 1 year ago

Describe the bug As of its v0.2.0+beta.3.73 1.18.2 release, VMP completely breaks Pehkui (https://www.curseforge.com/minecraft/mc-mods/pehkui). Neither generate any log errors, but when loaded together, Pehkui cannot modify the scales of players (and presumably any entity, though i'll admit I didn't think to test that). The /scale command will execute, and using "/scale get" will indicate that the scale has been modified, but it obviously hasn't, as the jump height, entity scale, reach, or any other scale type will not change. Downgrading VMP to v0.2.0+beta.3.69 or lower gets rid of the issue.

This bug also affects any mod that relies on Pehkui for its entity scaling, such as Origins and CPM.

To Reproduce Steps to reproduce the behavior:

  1. Load v0.2.0+beta.3.73 or higher of VMP alongside Pehkui
  2. Try to modify any scale using /scale

Expected behavior The two mods working normally alongside each other

Screenshots

n/a

Runtime info (please complete the following information):

Crash reports / logs

n/a

Other mods

None, besides the mods' respective dependencies

Checklist

Additional context

Tempest-5ky commented 1 year ago

Update: possible fix on pehkui's end? https://github.com/Virtuoel/Pehkui/issues/305#issuecomment-1200514708

ishland commented 1 year ago

Closing as resolved since pehkui will have a fix in their next release: Virtuoel/Pehkui#305

Feel free to open a new ticket if it happens again with their next release.