VMP and betterfpsdistance conflict

[AlexanderwithaA]

Describe the bug vmp causes betterfpsdistance to not work correctly, betterfpsdistance changes minecraft to render in a circle since fog covers the corners, having vmp stops that.

To Reproduce

1. install the fabric versions of vmp and betterfpsdistance along with necessary dependencies.
2. create a new world and fly up high to so you can see where the corners of the rendered area are/should be. (a mod to disable fog might be useful to see this)

Expected behavior the rendered area is circular.

Screenshots betterfpsdistance only both mods

Runtime info (please complete the following information):

• OS: windows 11
• Minecraft version: 1.20.4
• Mod version: vmp-fabric-mc1.20.4-0.2.0+beta.7.135-all
• Mod branch: (fill this if you are not using the default ver branches)

Crash reports / logs https://mclo.gs/ZZ3bMKT

Other mods https://pastebin.com/hstjqDpU

Checklist

• [x] I am using the official version of the mod.
• [x] I tried the latest development version but the issue persists.
• [x] I searched for similar open issues and could not find an existing bug report on this.

Additional context I'm using vulkanmod instead of sodium

[ishland]

Working as intended.

VMP replaces the chunk sending to make it cost less to track sent chunks, and the square chunk sending behavior is intentional.

You have already disabled the fog, chunks behind the fog should still render.

[ishland]

Oops didn't mean to close this

[AlexanderwithaA]

I was just looking at this again because vmp was making my performance worse, mojang made chunk rendering cylindrical in snapshot 21w37a, could vmp reflect this change? https://minecraft.wiki/w/Java_Edition_21w37a#General_2

[ishland]

I was just looking at this again because vmp was making my performance worse, mojang made chunk rendering cylindrical in snapshot 21w37a, could vmp reflect this change? https://minecraft.wiki/w/Java_Edition_21w37a#General_2

Chunk rendering should already be cylindrical if both fog and fog occlusion is enabled. And as I mentioned above, the revert to square chunk sending behavior is intentional in VMP. Chunk loading in vanilla is also never cylindrical even after 21w37a.

[AlexanderwithaA]

I'm talking about rendering not loading, what I'm concerned about is that the rendering with vmp is square while in vanilla it's cylindrical. Top image is 1.18.2 vanilla, middle is 1.18.2 with vmp, and bottom is 1.20.2 vanilla. So is it intentional that vmp renders chunks in a square?

[ishland]

It is intentional.

There are a few reasons for this:

• Quite some optimization in vmp assumes that square render distance is used.
• Making server-sided tracking of square render distance is cheaper than the cylindrical one.
• It is the rendering optimization mod's job to cull chunks behind the fog.