RelativityMC / VMP-fabric

A Fabric mod designed to improve server performance at high playercounts.
MIT License
136 stars 8 forks source link

Memory Leak Fix & VMP conflict on 1.20.1 fabric #57

Closed neinwhal closed 6 months ago

neinwhal commented 6 months ago

Describe the bug Game in 1.20.1 crashes with only both the latest memory leak fix mod (1.1.4) + VMP (0.2.0+beta.7.102) and the associated fabric apis.

To Reproduce Steps to reproduce the behavior:

  1. Get fabric 1.20.1 loader and apis
  2. Get memory leak fix + very many players

Runtime info (please complete the following information):

Crash reports / logs https://pastebin.com/raw/F8X1SYaV

Checklist

Additional context This seems to only occur after the recent updates in memory leak fix, it occurs with both 1.1.4 and 1.1.3 of memory leak fix, but 1.1.2 works fine. Because the logs outputs an error from vmp, i thought to report here, but its a memory leak fix issue, lmk, and ill start one up there too.

ishland commented 6 months ago

It seems that you are trying to run a 1.17 version of memoryleakfix on 1.20.1.

neinwhal commented 6 months ago

memory leak fix has always been labelled as 1.17+?

image

And the version is supported as so on modrinth.

neinwhal commented 6 months ago

^ For version 1.1.3 it's clearly stated to support 1.20.x as well, and that still results a crash. The only compatible version as of now is 1.1.2.

ishland commented 6 months ago

From the error it is clearly a version mismatch. But please try reproduce without VMP.

neinwhal commented 6 months ago

Memory fix leak 1.1.4 seems to be working fine though without VMP, even with other mods and various other major optimization mods. This might be more of an issue from memory fix leak's side conflicting with you then? If so ill redirect the report there.

neinwhal commented 6 months ago

Ok yeah, confirmed, sometimes it crashes on *loading world with memory fix leak 1.1.4. Thanks, will redirect there.