RelativityMC / VMP-fabric

A Fabric mod designed to improve server performance at high playercounts.
MIT License
136 stars 8 forks source link

Carpet mod fake player doesnt appear with use_async_chunks_on_login=true #58

Closed juls0730 closed 3 months ago

juls0730 commented 4 months ago

Describe the bug When spawning carpet mod fake players, for example /player Alex spawn in the console logs, it says that Alex joined the game, then VMP says "Async chunk loading for player Alex completed", and the Alex fake player appears in the tab menu, however, the fake player does not appear.

To Reproduce Steps to reproduce the behavior:

  1. Install carpet mod and optionally apply this patch or download the patched version from my Dropbox if you trust a random stranger on the internet. I have this patch applied in order to get C2ME to work with carpet fake players, I don't think it affect the VMP issue, but just an important note
  2. /player Alex spawn
  3. Alex joined the game, but does not exist

Expected behavior Alex should join the game and act like a normal player, you can see the expected behavior if you set use_async_chunks_on_login to false in the vmp.properties

Screenshots N/A

Runtime info (please complete the following information):

Crash reports / logs No crash or logs reported

Other mods Carpet mod

Checklist

Additional context I believe #39 is the same issue

ishland commented 3 months ago

There is obviously some warnings when this is happening:

[Server thread/INFO] (Minecraft) Alex[local] logged in with entity id 813 at (20.975955376011925, 63.0, 16.650653411210776)
[Server thread/INFO] (Minecraft) Alex joined the game
[Server thread/INFO] (Minecraft) Async chunk loading for player Alex completed
[Render thread/INFO] (Minecraft) [System] [CHAT] Alex joined the game
[Render thread/WARN] (Minecraft) Server attempted to add player prior to sending player info (Player id ec561538-f3fd-461d-aff5-086b22154bce)
[Render thread/WARN] (Minecraft) Skipping Entity with id entity.minecraft.player

Not providing any logs lowers the priority of this issue. Anyways, a fix is on the way.

juls0730 commented 3 months ago

Thank you. I apologize for missing warnings in the logs, and not providing any in the first place.