RelativityMC / VMP-fabric

A Fabric mod designed to improve server performance at high playercounts.
MIT License
136 stars 8 forks source link

Immersive Portal entity rendering incompabilities #59

Closed Senjosei closed 3 months ago

Senjosei commented 3 months ago

Describe the bug Regardless if there's a portal or not, when its loaded with immersive portals, in certain conditions, entities (block entities too) may not render, when the config option use_optimized_entity_tracking is set to true. Setting it to false fixes the issue

To Reproduce Steps to reproduce the behavior:

  1. Get on a super flat world with the config option use_optimized_entity_tracking set to true
  2. Create a 4 block high pillar
  3. Stand on the ground and place a sand block on the side of the pillar
  4. Observe the invisible sand block entitiy lol. (If the falling block entity is still visible, try various heights and camera angle when placing the sand.)

Expected behavior The falling block entity to be visible the whole way down.

Runtime info (please complete the following information):

Crash reports / logs No errors on logs

Other mods (Minimal reproducible)

Checklist

ishland commented 3 months ago

From brief investigation immersive portals and VMP's entity tracking optimization are both attempting to manage entity trackers and these management doesn't co-exist. You'll have to disable one of them.

VMP's entity tracking optimization assumes that only nearby entities are visible to players.