RelativityMC / raknetify

A Fabric mod / Velocity plugin / BungeeCord plugin that uses RakNet to improve multiplayer experience significantly under unreliable and rate-limited connections.
MIT License
148 stars 2 forks source link

Mixin transformation of ServerLoginNetworkAddon fails with Fabric API 0.58.5 #13

Closed AViewFromTheTop closed 2 years ago

AViewFromTheTop commented 2 years ago

Describe the bug With Raknetify and Fabric API 0.58.5, it's impossible to join servers and singleplayer worlds.

To Reproduce Steps to reproduce the behavior:

  1. Try to join a server or singleplayer world.
  2. Unable to join, log says that Raknet's Mixin for Fabric API's ServerLoginNetworkAddon failed.

Expected behavior You'd be able to join singleplayer and multiplayer worlds normally.

Screenshots 2022-08-03_06 47 19

Runtime info (please complete the following information):

Crash reports / logs 03.08 10:47:58 [Server] Netty Epoll Server IO #2/INFO [STDERR]: java.lang.RuntimeException: Mixin transformation of net.fabricmc.fabric.impl.networking.server.ServerLoginNetworkAddon failed

Other mods Fabric Api 0.58.5

Checklist

ishland commented 2 years ago

This is not a valid logs. Please paste full logs.

AViewFromTheTop commented 2 years ago

This is not a valid logs. Please paste full logs.

2022-08-03-3.log Says something about the Mixin already being redirected by Fabric API itself.

ishland commented 2 years ago

Try adding -Draknetify.debug=true to your server jvm flags and reproduce this again.

AViewFromTheTop commented 2 years ago

Try adding -Draknetify.debug=true to your server jvm flags and reproduce this again.

Just tried, I don't think the output is any different. I ran it on a singeplayer world this time since Apex doesn't let me modify server arguments, but I still get the same error nonetheless. latest.log

ishland commented 2 years ago

I don't think you have actually added the flag correctly. Also the version shown in the startup log is 0.1.0+alpha.5.2 rather than 0.1.0+alpha.5.4.

AViewFromTheTop commented 2 years ago

I don't think you have actually added the flag correctly. Also the version shown in the startup log is 0.1.0+alpha.5.2 rather than 0.1.0+alpha.5.4.

I'm using a5.4 and the log doesn't mention otherwise. My jvm flags look like this, though I'll try it again: -Draknetify.debug=true -Xmx4G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M

ishland commented 2 years ago

Your log did mention it is 0.1.0+alpha.5.2 image

AViewFromTheTop commented 2 years ago

Your log did mention it is 0.1.0+alpha.5.2 image

The newer log doesn't, and I get the same issue. Here's another log, I think the debug flag worked this time. latest.log