RelativityMC / raknetify

A Fabric mod / Velocity plugin / BungeeCord plugin that uses RakNet to improve multiplayer experience significantly under unreliable and rate-limited connections.
MIT License
148 stars 2 forks source link

Potential memory leak? #9

Closed Neubulae closed 2 years ago

Neubulae commented 2 years ago

Describe the bug After prolonged connection, the player eventually runs out of memory. The problem doesn't exist outside a Raknet connection, and, once the problem happens, it prevents player from further rejoining the server again with Raknet, only restarting the game works.

To Reproduce Steps to reproduce the behavior:

  1. Join server with Raknet
  2. Idle
  3. Gets kicked

Screenshots 图片

Runtime info (please complete the following information):

Crash reports / logs https://0x0.st/oQly.txt

Other mods https://0x0.st/oQlt.txt

Checklist

IAmSneak commented 2 years ago

I've gotten the same issue in 1.19 versions using the official version of the mod and latest development. Also happens on the server with this log

ishland commented 2 years ago

Try reproduce with jvm flag -Dio.netty.leakDetection.level=advanced

IAmSneak commented 2 years ago

common mods:

Neubulae commented 2 years ago

As the log is extremely big I'll just paste it here https://0x0.st/oQhi.log

ishland commented 2 years ago

Try reproduce again with latest devbuild.

Neubulae commented 2 years ago

Try reproduce again with latest devbuild.

reproduces, do I need to provide a log again?

ishland commented 2 years ago

reproduces, do I need to provide a log again?

Yes definitely

Neubulae commented 2 years ago

it will take some time to reproduce a log, brb

ishland commented 2 years ago

Try reproduce with latest devbuild and provide logs if it still leaks.

Neubulae commented 2 years ago

the log is no longer spammed by things now so I think it's now fine? I'll wait and see

Neubulae commented 2 years ago

I don't reproduce with the latest build, thx pal.

ishland commented 2 years ago

Remember to remove the flag since the advanced leak detector comes with some performance overhead.