ReliaQualAssociates / ramstk

Reliability, Availability, Maintainability, Safety (RAMS) analysis program.
https://www.reliaqual.com/rtk/
BSD 3-Clause "New" or "Revised" License
44 stars 15 forks source link

Handle Errors in Hardware BoM Data Model insert() Method #83

Closed weibullguy closed 6 years ago

weibullguy commented 6 years ago

Expected Behavior

In the Hardware bill of materials (BoM) data model, the insert() method has to insert a record into each of the RTKDesignElectric, RTKDesignMechanic, RTKMilHdbkF, RTKNSWC, and RTKReliability database tables for the new hardware item. This Hardware BoM data model does this by calling the insert() method for each, respective data model (five separate insert() calls). Each of these calls returns an error code and error message.

The hardware BoM data model should return an error code and error message that aggregates all the error codes and error messages in some way. This should be used to generate debug log and error dialog messages to notify the user there was a problem.

Actual Behavior

The error codes and error messages are ignored; nothing is done with them. Adding a new hardware item fails silently.

Steps to Reproduce the Problem

  1. Launch RTK.
  2. Open a program database in RTK.
  3. Select the Hardware tab in the Module Book.
  4. Select a line in the Hardware Module Book.
  5. Attempt to insert a sibling or insert a child.

Operating Environment

weibullguy commented 6 years ago

Fixed in commit bd4a5cd7988a5eeebb236d700caadf82cf121798