search

Rello / audioplayer

Audio Player for Nextcloud and ownCloud
https://rello.github.io/audioplayer
GNU Affero General Public License v3.0
223 stars 54 forks source link

[BUG] Dashboard Widget - not playing pls playlists #583

Closed kenda closed 11 months ago

kenda commented 2 years ago

Describe the bug I have a couple of pls playlists which are working fine in the app itself. But they are not playing in the dashboard widget.

I found this special handling here: https://github.com/Rello/audioplayer/blob/a7984dca1098bc1d58941e7b41fe333db93cacfe/js/dashboard.js#L355-L358 Which seems to handle the playlists like pls. Not sure if the break might be the problem already.

Expected behavior After selecting a playlist, I should be able to play it.

Versions:

kenda commented 1 year ago

I had a little look at it and it seems that the break is basically preventing the following CSP issue that the streams are not allowed because of the media-src CSP. The app itself is adding a wildcard here but I doubt that this is possible for the dashboard page.

Rello commented 11 months ago

thats correct here. the app itself can set alternative CSP - to do this for the dashboard, which includes other apps also, would be fatal