Reloaded-Project / Reloaded-II

Universal .NET Core Powered Modding Framework for any Native Game X86, X64.
GNU General Public License v3.0
583 stars 80 forks source link

Enhancement: Detection of Problematic Locations of Target Game or Reloaded Folder #477

Open dreamsyntax opened 20 hours ago

dreamsyntax commented 20 hours ago

Games can fail to load properly if either the target game path OR Reloaded-II's primary folder...

Describe the solution you'd like

Alternatives

This may be a bit tricky to account for all cases and not negatively impact any Linux users. I'm not sure if we could reliably detect other cloud providers (such as DropBox) - so rather than a perfect solution, the highest priority imo is accounting for Windows 11 default case of OneDrive and the conflict with Desktop.

I plan to look into implementing a PR for this issue, but it may only partially resolve.

Sewer56 commented 2 hours ago

Unusually detailed ticket, I like those.

if either a game path

If a game path itself has special characters, you can probably assume the game handles itself fine.


In any case, Reloaded-II itself has no issues with paths with special characters, aside from extraction with 7z.dll in case of special characters which may be fixable.

I think the best solution would be simply not installing R2 to OneDrive or a location with special characters. For the latter, path to Desktop will have OneDrive in it, for the former, check the character set.

Since the installer runs as admin, you could fallback to C:/Reloaded-II in those cases; assuming that a typical user can write to that path. That needs to be checked however.