Rem0o / FanControl.Releases

This is the release repository for Fan Control, a highly customizable fan controlling software for Windows.
Other
14.21k stars 447 forks source link

unpresent sensor leads to removed fan curve but latter is still shown in a mix #1363

Open bobdig opened 1 year ago

bobdig commented 1 year ago

Minor problem, probably more a suggestion: I switched Motherboards and one sensor, which had a fan curve called "Linear VRM" attached to it, isn't present at the new board. And with that, that fan curve isn't there either or at least it is not shown in the UI. Interestingly, that fan curve is still present at a Mix and no sign of an error (other then NaN%, now that I look closely at my own image).

So I think it would be great to have a check for the mixes, if those fan curves still exist. Graphically it maybe could be shown by a red x instead of a green one. See the attached picture.

Thank you for reading and awesome work Rémi. I hope that hasn't been reported before.

Screenshot 2022-12-12 151721

Rem0o commented 1 year ago

Hi,

That's kind of an extreme edge case, where I wouldn't even expect a config to be valid if you switch motherboards, since all sensors can be different.

In your case, the fan curve with the missing sensor failed to load, and the mix fan curves "remembers" the missing fan curve, so if it would be able to come back if say, the missing sensor came back, it would still be included in the mix. However in the config your are showing, that fan curves invalidates the mix.

Will add a message in between the parenthesis "Missing fan curve" so the behavior is more obvious.

bobdig commented 1 year ago

Thankfully it is working so it is really a minor thing. I now searched the config file, because I had recreated the curve "Linear VRM" three times now and I found it three times in the config but it looks like it is all with the new sensor, so no over-lefts, at least I think. A red x would be nice but another message will be good enough too I guess. Thank you.

Ketoyu commented 1 year ago

I've been having a recurring issue where occasionally Fan Control "can't find" certain sensors from HWInfo and "NVApiWrapper" (maybe the identifiers get shuffled or something) on startup, causing the curves to disappear entirely. No hardware has changed, haven't pinned down what's triggering it. I've been working around it by copy-pasting the userConfig.json, find-replacing all identifiers in the JSON with CPU identifiers, loading that, and using the UI to re-select the correct sensors.

For those cases, it would be helpful to have the curves at least load with "Sensor Not Found" so I can re-select them without editing the JSON.

EDIT: Quitting (via system-tray) and re-opening the app doesn't fix it, so it's not just the Windows-startup delay.

EDIT 2, 04/16/2023: Haven't had trouble with it in a while, currently on update 153. Will keep an eye & post details / potential factors if it happens again.

Ketoyu commented 1 year ago

Seems that when you add/remove a storage drive from the system, Fan Control loses the HWInfo sensor selections on the curve (error page with a list of "Graph Fan curve [curvename], missing sensor with identifier: HWInfo/[sensorID]", specific example "Graph Fan curve G-Core>F_G-Core, missing sensor with identifier HWInfo/17_16777216".

However, the curves no longer disappear and the sensor names can simply be re-selected in "Temperature source" on each curve. A very welcome change and good enough for me 👍

EDIT: perfect world, it would be nice if it could attempt to auto-select the sensors by name based on what they used to be. But, icing on the cake.

EDIT 2: (in case anyone else runs into this: ) purging some storage devices today with diskpart -> select disk # -> clean all (ofc dropping partitions / drive letters), which also caused some of the HWInfo sensors in Fan Control to read the wrong temperatures (i.e. 3090 memory 8°C but HWInfo reads ~56°C). This is resolved by opening the upper-right menu and clicking "Refresh sensors detection".