Rem0o / FanControl.Releases

This is the release repository for Fan Control, a highly customizable fan controlling software for Windows.
Other
14.31k stars 450 forks source link

Fan control does not allow to change Affinity #2527

Closed rolex20 closed 5 months ago

rolex20 commented 5 months ago

I have a 12700K CPU with P-Cores and Efficient-cores. When I change the affinity to FanControl to run only on efficient cores (My games are assigned the P-Cores only), taskmanager accepts but then FanControl returns to affinity to all cpu's. Can you please allow changing the affinity?

curious-city commented 5 months ago

Is it imporant if FanControl runs on P- or E-Cores? The app barely uses any system ressources anyway, so it shouldn't be a concern.

Rem0o commented 5 months ago

FanControl doesn't mess with its process affinity or anything like that, so I don't know how I could "allow" changing affinity.

rolex20 commented 5 months ago

This is about deciding which resources i want to give to fancontrol to optimize my own system. As I said, task manager allows changing the affinity and it accepts. Immediately I check again and the affinity is resetted to all cpu's. This means that the program checks and reassigns it's own affinities. I know some programs that don't allow this change so task manager fails when trying to change. But in this case there is no error, just that when you check again ,the affinities are resseted to all cpu's. If fancontrol itself does not reset it's own affinities, how else could this happen?

Rem0o commented 5 months ago

Nevermind, found it: image

It's in the Ring0 code from LHM: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/blob/3959e8e3c04452fed566e88fb40d0847a64581d8/LibreHardwareMonitorLib/Hardware/Ring0.cs#L331

Most likely due to this: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/issues/330

rolex20 commented 5 months ago

thank you Rem0o!, any chance not executing that line with a configuration option or some other way? (not all cpus are AMD ZEN)

Rem0o commented 5 months ago

Not really, as the thread affinity seems required to read each cores sensor.

rolex20 commented 5 months ago

ok, I understand, but thanks for the reply