Closed natethegreatINL closed 1 year ago
Hi @natethegreatINL first the PR has conflicts with the main branch that you will have to resolve.
You can try and do it here or you can do it locally by: 1) pulling the latest version of main 2) merging main in your branch
I'll have a look at the numbers now.
Patch coverage: 100.00%
and project coverage change: +0.01%
:tada:
Comparison is base (
56e04d7
) 98.69% compared to head (ee84722
) 98.70%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi Remi, glad I could contribute! I was considering adding the data points, but Tommy and I decided to just add the arrhenius values. I can totally add the points though and the extrapolated tritium data. Do you want me to add the points to replace the Arrhenius values or just on top of them? thanks
Let's discuss it in #262 for now :-)
There are pros and cons for both options and it's good that we have this discussion
Here is my PR with TZM properties.