RemDelaporteMathurin / h-transport-materials

:bar_chart: Easily access hydrogen transport properties
https://h-transport-materials.readthedocs.io
MIT License
15 stars 12 forks source link

Add tzm #261

Closed natethegreatINL closed 1 year ago

natethegreatINL commented 1 year ago

Here is my PR with TZM properties.

RemDelaporteMathurin commented 1 year ago

Hi @natethegreatINL first the PR has conflicts with the main branch that you will have to resolve.

You can try and do it here or you can do it locally by: 1) pulling the latest version of main 2) merging main in your branch

I'll have a look at the numbers now.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (56e04d7) 98.69% compared to head (ee84722) 98.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #261 +/- ## ========================================== + Coverage 98.69% 98.70% +0.01% ========================================== Files 74 75 +1 Lines 1756 1781 +25 ========================================== + Hits 1733 1758 +25 Misses 23 23 ``` | [Files Changed](https://app.codecov.io/gh/RemDelaporteMathurin/h-transport-materials/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=R%C3%A9mi+Delaporte-Mathurin) | Coverage Δ | | |---|---|---| | [h\_transport\_materials/material.py](https://app.codecov.io/gh/RemDelaporteMathurin/h-transport-materials/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=R%C3%A9mi+Delaporte-Mathurin#diff-aF90cmFuc3BvcnRfbWF0ZXJpYWxzL21hdGVyaWFsLnB5) | `98.11% <100.00%> (+0.01%)` | :arrow_up: | | [...\_transport\_materials/property\_database/\_\_init\_\_.py](https://app.codecov.io/gh/RemDelaporteMathurin/h-transport-materials/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=R%C3%A9mi+Delaporte-Mathurin#diff-aF90cmFuc3BvcnRfbWF0ZXJpYWxzL3Byb3BlcnR5X2RhdGFiYXNlL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [h\_transport\_materials/property\_database/tzm.py](https://app.codecov.io/gh/RemDelaporteMathurin/h-transport-materials/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=R%C3%A9mi+Delaporte-Mathurin#diff-aF90cmFuc3BvcnRfbWF0ZXJpYWxzL3Byb3BlcnR5X2RhdGFiYXNlL3R6bS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

natethegreatINL commented 1 year ago

Hi Remi, glad I could contribute! I was considering adding the data points, but Tommy and I decided to just add the arrhenius values. I can totally add the points though and the extrapolated tritium data. Do you want me to add the points to replace the Arrhenius values or just on top of them? thanks

RemDelaporteMathurin commented 1 year ago

Let's discuss it in #262 for now :-)

There are pros and cons for both options and it's good that we have this discussion