search

Rembane / lemmingpants

A system to handle the speakerlist on Datateknologsektionens meetings.
Apache License 2.0
6 stars 5 forks source link

Added dockerfiles and docker-specific configs. #59

Closed toasterbag closed 6 years ago

toasterbag commented 6 years ago

Things kinda work. As i can see everything builds and gets served correctly, however visiting localhost:8000 to access the lemmingpants-frontend only yields a blank page. Even if it doesn't fully work perhaps you can find something of help.

Also seems to maybe perhaps be slightly non-determenistic, if docker-compose up fails at first then try again :)

Rembane commented 6 years ago

When you have answered the following questions and fixed the stuff in the list we're one step closer to merge. :D

  1. How do I use this new, cool functionality? By running docker-compose up?
  2. It seems like I need to be root to run this, how hard is it to let me run everything as a non-privileged user?
  3. Add documentation on how to use this to README.md.
toasterbag commented 6 years ago

Yessir, the README.md should already have the basic instructions necessary for the setup see the header "Running with docker". it mosly just says that you should run build-docker.sh and then docker-compose up.

As for running as a non-privileged user: running the docker commands themselves as a normal user should work if your docker setup allows it, either via a special docker group or different permissions for var/run/docker.sock. Running the containers themselves as different users via the USER docker directive might however be a trivial task.

toasterbag commented 6 years ago

I also seem to have missed the docker-compose file, i will commit accordingly.

Rembane commented 6 years ago

Merged pull request in b7fdce2724e75e2a15862262a2469de3195cfaeb.

Thank you @toasterbag !