Remboooo / homgarapi

HomGar smart garden API client
MIT License
5 stars 2 forks source link

Pypi package + workflow request. #1

Closed RenierM26 closed 2 months ago

RenierM26 commented 3 months ago

Hi There,

I would like to assist you with this library and a home assistant integration. Would you be so kind as to create a pypi package?

May I also suggest using a github action to automate deployment to pypi? (That triggers on release)

Thank you for all the work so far!

wehrmannit commented 3 months ago

I can help you with the missing methods/calls, this project isn’t complete.

i just suck at python and couldn’t make it work in HA

Remboooo commented 2 months ago

Hi, thanks for your interest. I looked into building a HA plugin and got intimidated by the work needed to create even the simplest of plugins, so the project kind of got abandoned. I've never created a pypi package, I'd be happy to look into doing that. However, this project is very unfinished and is just in the proof-of-concept stage at the moment.

Remboooo commented 2 months ago

Hi There,

I would like to assist you with this library and a home assistant integration. Would you be so kind as to create a pypi package?

May I also suggest using a github action to automate deployment to pypi? (That triggers on release)

Thank you for all the work so far!

I've blown the dust off this project a bit and added a lot of documentation to the source. Then I published the package on pypi and added a github action. I'm not sure about the correct workflow on updating the version and download URL in setup.py and then actually creating the release on github. They are separate manual steps for now. Any recommendations on how to tie these actions together?

Remboooo commented 2 months ago

Well, it releases to pypi automatically using a github action when a release is created now, using the tag as version number. I'm calling this a success and closing this ticket :)