search

Remedy-Entertainment / binderoo

Rapid iteration framework.
Other
48 stars 7 forks source link

pragma(inline) #4

Open TurkeyMan opened 8 years ago

TurkeyMan commented 8 years ago

Just out of curiosity, why all the explicit pragma(inline)? Was there a measured improvement, or observed cases of bad codegen? DMD is pretty ordinary at inlining, but I think LDC is the future... why not just leave the judgement to LLVM? It seems a bit blunt to tag everything.

GooberMan commented 8 years ago

I've not done any measurements, but as long as it's planned to have multiple compilers supported the safest option is to not trust the compiler. Especially when the MS toolchain is involved in any capacity (ie DMD win64).

TurkeyMan commented 8 years ago

Looking at it case-by-case, it doesn't look like it's a big problem. I definitely don't think the quat mul's should be inline, they're quite a lot of work. There's no vector/matrix functions here yet, which I expect would be the biggest offenders, but I was just generally concerned by the pattern.

TurkeyMan commented 8 years ago

Also, I don't think you'd use DMD-win64 for release builds. LDC-win64 is way superior.