Remeic / vue-highlighter

🏷 Vue directive for highlight multiple istances of a word
MIT License
39 stars 13 forks source link

prop "text" did not update properly #11

Closed shilik closed 6 years ago

shilik commented 6 years ago

Hi, I got a problem of updating the property of "text" I tried to make the content of "text" change based on the need of users. But the content of "text" didn't update accordingly when a new value is assigned to it. any suggestion?

snipaste_2018-05-19_13-09-43 The test code is as the following: snipaste_2018-05-19_13-11-52

Remeic commented 6 years ago

Hi @shilik, i'm figure it out with @astagi but for now seem there is no solution, when a directive is bind to element, element doesn't update correctly

I will continue to look for a solution

shilik commented 6 years ago

Hi, @Remeic Thank you for the response. Hopefully, this issue will be resolved sooner.

Best regards,

shilik commented 6 years ago

Hi, jtommy Does this mean the problem above is solved?

shilik

Remeic commented 6 years ago

@shilik sorry for the delay, in the last week I was submerged in things to do, tomorrow I accept the pr

shilik commented 6 years ago

@Remeic Thank you very much.

shilik

Remeic commented 6 years ago

@shilik Sorry for delay

shilik commented 6 years ago

snipaste_2018-06-01_07-39-55 snipaste_2018-06-01_07-41-43

well, It seems nothing changed even after the patch. Any suggestion?

Remeic commented 6 years ago

@shilik try to update now the node module

shilik commented 6 years ago

@Remeic I noticed the version no. is updated. So I tried to update the plugin again, but nothing changed as a result. Please let know when this issue is fixed. Thank you very much.

Remeic commented 6 years ago

@shilik Sorry for delay, can you share your code? because i can't replicate this issue

shilik commented 6 years ago

@Remeic Thanks for the response and great patch! It works great on my projects now! Credit to you! :)

Shilik fast_reading

Remeic commented 6 years ago

thank you @shilik! I'm so happy that everything works and that you use the directive in a real project, thank you very much!