search

Remeic / vue-highlighter

🏷 Vue directive for highlight multiple istances of a word
MIT License
39 stars 13 forks source link

Update Travis to build against node 8 #17

Closed burrelle closed 5 years ago

burrelle commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files           2        2           
  Lines          70       70           
=======================================
  Hits           69       69           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b690522...85f877b. Read the comment docs.

Girxffe commented 5 years ago

Looking at the build logs, node 10 isn't supported. Remove node 10 and keep support for 8 👌

Remeic commented 5 years ago

Thanks for PR! @Girxffe @burrelle I will open a new issue for node 10 support