switch build to rollup from bili

Remeic / vue-highlighter

🏷 Vue directive for highlight multiple istances of a word

MIT License

39 stars 13 forks source link

switch build to rollup from bili #28

Open khamer opened 4 years ago

khamer commented 4 years ago

To address Issue #26. I tested using the esm, cjs, and iife (with vue from the cdn) using Parcel locally. Let me know if it needs any changes or you're seeing any issues and I'll get them fixed.

Remeic commented 4 years ago

Hi @khamer, thanks for this PR, can remove even "babel-preset-poi": "^10.0.2" and use @babel/preset-env Please make attention to presets on babel config!

khamer commented 4 years ago

Hey @Remeic - I think I've made the changes you were looking for. It's now using @babel/preset-env and I did the recommended steps for libraries and used @babel/plugin-transform-runtime as well. npm test fails but it fails for me even without the PR too, so I'm not sure if that's being used.

khamer commented 4 years ago

Hey @Remeic - is there something else you're looking for here? Happy to make more changes.

Remeic commented 4 years ago

I wish add hacktoberfest accept label just in time, sorry for delay i have a lot of work to do in these days. @khamer if in future you want to check the failing test you make me very happy!