Failing demos

[Remi-Gau]

Failed demos

Documented in this issue: https://github.com/Remi-Gau/bids-app_rsHRF/issues/1

Using Matlab 2017a on Ubuntu 18.04

The following demos do not run:

• rsHRF_demo_impulseest.m

No public property RegularizationKernel exists for class idoptions.impulseest.

Error in rsHRF_demo_impulseest (line 15)
options.RegularizationKernel = 'none'; %Regularizing kernel, used for regularized estimates
of impulse response for all input-output channels. Regularization reduces variance of
estimated model coefficients and produces a smoother response by trading variance for bias

• rsHRF_demo_voxel_calcium.m

Error using figure
There is no WindowState property on the Figure class.

Error in rsHRF_demo_voxel_calcium (line 111)
figure('WindowState','maximized');

• rsHRF_demo_LFP_IOS.m with flag_all=1;

Undefined function or variable 'wgr_get_parameters'.

Error in rsHRF_demo_LFP_IOS>@(x)wgr_get_parameters(hrf_Blind(:,x),dt)

Error in rsHRF_demo_LFP_IOS (line 97)
        PARA = arrayfun(@(x) wgr_get_parameters(hrf_Blind(:,x),dt),1:size(hrf_Blind,2),
        'UniformOutput', false);

• rsHRF_demo_LFP_IOS.m with flag_sliding_windows=1;

Undefined function or variable 'wgr_get_parameters'.

Error in rsHRF_demo_LFP_IOS>@(x)wgr_get_parameters(hrf_Blind(:,x),dt)

Error in rsHRF_demo_LFP_IOS (line 97)
        PARA = arrayfun(@(x) wgr_get_parameters(hrf_Blind(:,x),dt),1:size(hrf_Blind,2), 'UniformOutput',
        false);

[NigelCol]

Hi Remi, thank you very much for the extensive review and very well documented issues of the rsHRF toolbox (matlab and python version).

Response to issues documented in #1.

The errors mentioned should now be resolved. Some errors were related to not backtesting the demos with previous matlab versions. The demos should now work for versions MATLAB 2016+.

Note that a license for the System Identification Toolbox is required in order to run some of the demos.

The fix for the issues are as following :

• rsHRF_demo_impulseest.m fixed in https://github.com/compneuro-da/rsHRF/commit/bd7f549c6a5c6c32f9bdf34d733a171a191a4688 and https://github.com/compneuro-da/rsHRF/commit/9eabb489e99eb707f322cc3ccfd5652215df1f12

  This was due to an inproper specification of the impulseestOptions (line 14);

  options.RegularizationKernel = 'none'; was replaced by RegulKernel = 'none'; and solves the issue.

 

• rsHRF_demo_voxel_calcium.m fixed in https://github.com/compneuro-da/rsHRF/commit/6a0085e8b3c9413ff1c7185f37a9380a2a917e01

  This was due to incompability with earlier MATLAB versions than 2018a.

  figure('WindowState','maximized'); was replaced by figure('units','normalized','outerposition',[0 0 1 1]) and solves the issue for older MATLAB versions.

 

• rsHRF_demo_LFP_IOS.m with flag_all=1 and flagg_sliding_windows=1; fixed in https://github.com/compneuro-da/rsHRF/commit/d122eefbc1525ffa8db49a7ba9bba4d3c1de6ccd

  This was due to a older function being defined that was not in the current repository. The proper function rsHRF_get_HRF_parameters has now been specified instead of wgr_get_parameters.

 

• An additional error not specified in #1 was fixed for rsHRF_demo_LFP_IOS.m with flag_all=1 and flagg_sliding_windows=1; (https://github.com/compneuro-da/rsHRF/commit/56ce05db29dc4d7d370e0a740bf2842766aceec6)